fix: add background job lock TTL configuration#204
Merged
Conversation
Add a background job lock with configurable TTL and conflict handling for indexer replay requests. Log lock acquisition and lock-expiration reclaim events to improve debugging of stuck jobs. Closes accesslayerorg#187 Made-with: Cursor
|
@wheval Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BACKGROUND_JOB_LOCK_TTL_MSwith a safe defaultPOST /api/v1/admin/indexer/replaywith the lock and return409when a lock is activeTest plan
pnpm exec jest src/utils/test/background-job-lock.utils.test.ts --runInBandpnpm exec eslint src/modules/admin/admin.controllers.ts src/utils/background-job-lock.utils.ts src/utils/test/background-job-lock.utils.test.ts src/config.ts/api/v1/admin/indexer/replaytwice quickly and verify second call returns409Closes #187